Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor universal property of suspensions #961

Merged

Conversation

fredrik-bakke
Copy link
Collaborator

@fredrik-bakke fredrik-bakke commented Dec 1, 2023

Refactors universal properties of suspensions to use the Level-naming scheme.

@EgbertRijke
Copy link
Collaborator

Wouldn't it be better convert to stating universal properties in UUomega only? I don't really know what the level-wise universal properties are good for

@fredrik-bakke
Copy link
Collaborator Author

Wouldn't it be better convert to stating universal properties in UUomega only? I don't really know what the level-wise universal properties are good for

Backward compatibility, I suppose.

@fredrik-bakke
Copy link
Collaborator Author

Also, sometimes it is used in Sigma types. E.g.

  universal-property-pushout-extension-by-equivalences :
    {l : Level}  is-equiv i  is-equiv j  is-equiv k 
    Σ (cocone f' g' X) (λ d  universal-property-pushout-Level f' g' d l)

@EgbertRijke
Copy link
Collaborator

Reference in new issue

Ah, your point is here. That code doesn't look very good to me. Looks like I have another refactoring job to do.

@EgbertRijke
Copy link
Collaborator

Wait I think I am already doing that refactoring in #885. Mind you I might have been addressing some of these universal properties there too.

@fredrik-bakke
Copy link
Collaborator Author

Wait I think I am already doing that refactoring in #885. Mind you I might have been addressing some of these universal properties there too.

Oh no. I was working on that right now

@EgbertRijke
Copy link
Collaborator

I think #885 is already much deeper in than you are here. Since this pr is <200 lines of code, perhaps it would be better to abandon this one. I'm really sorry.

@fredrik-bakke
Copy link
Collaborator Author

Well, 200 LOC is what I've pushed...

@fredrik-bakke
Copy link
Collaborator Author

Also, there doesn't seem to be any overlap in what I've actually pushed. Am I missing something?

@fredrik-bakke
Copy link
Collaborator Author

I decided to just ignore the up problem for now, as it seems to be a more delicate problem than I first anticipated.

@fredrik-bakke fredrik-bakke marked this pull request as ready for review December 2, 2023 01:48
@fredrik-bakke fredrik-bakke changed the title Refactor universal properties Refactor universal property of suspensions Dec 2, 2023
@fredrik-bakke fredrik-bakke marked this pull request as draft December 2, 2023 18:58
@fredrik-bakke fredrik-bakke marked this pull request as ready for review December 2, 2023 21:52
@fredrik-bakke fredrik-bakke merged commit 2101307 into UniMath:master Dec 10, 2023
4 checks passed
@fredrik-bakke fredrik-bakke deleted the refactor-universal-property branch December 10, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants